[mythtv] [Bug][Patch] SetBookmark putting String "NULL" in db

[Steven]

Chris Pinkham schreef:

>>no comments?
>>    
>>
>
>Can you send this a third time? :)  Some of us have pretty hard heads. :)
>
>  
>
>>Just in case I'll describe the symptoms this "Bug" has here:
>>
>>After clearing a Bookmark from a recording the Icon on the View Recordings
>>Screen is still showing (Titivillus Theme). This was caused by SetBookmarks
>>setting the value of Bookmark to "NULL" and not NULL on clearing the
>>Bookmark.
>>    
>>
>
>This explanation helps, the first time I saw your post, I knew the
>ProgramInfo::GetBookmark code was doing a sscanf on the value retrieved from
>the bookmark column, so I figured the NULL was getting sscanf-ed to 0 so I
>couldn't think of the bug you were seeing.
>
>  
>
>>I can't really believe I'm the only one who is affected by this? Or is it
>>just a matter of QT/mysql-Version?
>>    
>>
>
>I confirmed it on my machine so the patch is now in CVS.  Thanks.  I also
>added code to dbcheck.cpp to convert any existing occurances of the string
>"NULL" to literal NULL in the recorded.bookmark column.
>
>  
>
Would this bug also explain this message I see in the log (CVS from a 
couple of days ago) ?

DB Error (delta position map insert):
Query was:
INSERT INTO recordedmarkup (chanid, starttime, mark, type, offset) 
VALUES ( NULL
'1003' , '20050208202400' , '5531' , 6 , '1497991206' );
Driver error was [2/1064]:
QMYSQL3: Unable to execute query
Database error was:
You have an error in your SQL syntax.  Check the manual that corresponds 
to your
 MySQL server version for the right syntax to use near ''1003' , 
'20050208202400
' , '5531' , 6 , '1497991206' )' at lin

Steven