[mythtv] filldata.cpp : --do_channel_updates bug
Luis Ochoa
luis.m.ochoa at gmail.com
Tue Dec 6 20:08:12 UTC 2005
In the relevant code section ~ line 926, there is:
926 dd_station_info.exec();
927
928 if (chan_update_q.size() > 0)
929 {
930 chan_update_q.prepare(
931 "UPDATE channel "
932 "SET callsign = :CALLSIGN, name = :NAME, "
933 " channum = :CHANNEL, freqid = :FREQID, "
934 " atscsrcid = :ATSCSRCID "
935 "WHERE xmltvid = :STATIONID AND sourceid = :SOURCEID;");
936 }
937 while (dd_station_info.next())
938 {
939 QString channel = dd_station_info.value(3).toString();
In line 928, I strongly suspect that what was intended was:
928 if (dd_station_info.size() > 0)
as "chan_update_q" is inside a nested loop in the previous section,
it's an update query (which returns -1 for size()), and altogether
doesn't make any sense here.
Luis.
More information about the mythtv-dev
mailing list