[mythtv] [PATCH] Remove use of deprecated DVB events.

Kenneth Aafløy lists at kenneth.aafloy.net
Wed Aug 31 14:11:59 UTC 2005


onsdag 31 august 2005, 12:21, skrev Stuart Auchterlonie:
> On Wed, Aug 31, 2005 at 05:39:26AM +0200, Kenneth Aafløy wrote:
> > Hi!
> >
> > This patch removes the FE_GET_EVENT usage in dvbchannel, not only because
> > it's deprecated, but because it's deprecated for a reason.  What's
> > happening here is that the events are flushed right after the card get's
> > a lock and thus dvbchannel deadlocks waiting for an event.
> >
> > The deadlock was caused by bad programming, but the user/kernel space
> > race of FE_GET_EVENT still exists.
> >
> > The event handling is replaced by a simple busy loop that waits for 5
> > consecutive status == lock over a maximum period of 5 seconds.
> >
> > At least I can change channel a few times without myth crashing or
> > deadlocking now :)
>
> Well for me it tries to tune to the initial channel, fails and SEGV. :(

AFAICS there is no change in that patch that could SEGV on it's own,
but it could be triggering unseen problems in other parts of MythTV.

And when looking over what I wrote last night, I notice that I should
not program when half-asleep. New patch attached, which actually do
check for a lock :)


Kenneth
-------------- next part --------------
A non-text attachment was scrubbed...
Name: eventlock.patch
Type: text/x-diff
Size: 6731 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20050831/63c4b012/eventlock.bin


More information about the mythtv-dev mailing list