[mythtv] Re: [mythtv-commits] mythtv commit: r7185 by danielk

[John Pullan]

On 30/08/05, John Pullan <john.pullan at gmail.com> wrote:
> On 30/08/05, Stuart Auchterlonie <stuarta at squashedfrog.net> wrote:
> > On Tue, Aug 30, 2005 at 07:43:53PM +0100, John Pullan wrote:
> > >
> > > Full scan, does seem to work although it seems to miss out an mplex.
> > > I've managed to get full tuned scan to work by the expedience of
> > > commenting out the test against current in
> > > SIScan::HandleSIParserEvents i.e
> > >
> > >     // ignore events before current is set
> > > //    if (current == scanTransports.end())
> > > //        return;
> > >
> > > wrong and hacky, but I thought I'd point it out. It doesn't pick up
> > > the first mux though. (dunno why as yet, it could be a timeout issue)
> > >
> >
> > I correctly get all 6 multiplexes when doing a full scan.
> >
> Sorry bad phrasing, I meant it created the dtv_multiplex entry but
> failed to find the services
> 
> > As for needing to comment out that bit of code....
> >
> > *idea comes to mind*
> >
> > when doing the full scan, is the mulitplex missed the first multiplex
> > that would be scanned?
> 
> I think it might have been the second.
> 
> >
> > If so it could possibly be a race condition. Why it would take time
> > for current to be setup correctly I'm not sure....
> >
> a better (I think ) fix would be :
> Index: siscan.cpp
> ===================================================================
> --- siscan.cpp  (revision 7185)
> +++ siscan.cpp  (working copy)
> @@ -1729,7 +1729,7 @@
>      if (!siparser)
>          return;
>      // ignore events before current is set
> -    if (current == scanTransports.end())
> +    if ((scanMode == TRANSPORT_LIST) && (current == scanTransports.end()))
>          return;
> 
>      if (serviceListReady)
> 
Ahmm, update, the "bit of bent coat hanger" I use for my aerial got
knocked which probably explained why it wasn't getting the channels.
But I also reset the timer in bool SIScan::ScanServicesSourceID(int
SourceID) as well. I'm not entirely sure if this was needed but the
thinking was to make sure that it had the full allocation of time to
try and find the services.

Regards
-- 
John