[mythtv] Re: denoise3d + Athlon XP bug

[Jay Merrifield]

I'm getting a compiler error on osdsurface.cpp:

g++ -c -pipe -march=k8 -Wall -W -O3 -Wall -Wno-switch
-fomit-frame-pointer `freetype-config --cflags` -D_REENTRANT -DPIC
-fPIC  -DMMX -Di386 -DUSING_IVTV -DUSING_DVB -DUSING_XRANDR
-DUSING_XVMC -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
-DPREFIX=\"/usr/local\" -DUSING_XVMCW -DUSING_XV -DQT_NO_DEBUG
-DQT_THREAD_SUPPORT -DQT_SHARED -I/usr/lib64/qt-3.3/mkspecs/default
-I. -I/usr/local/include -I/usr/include -I../.. -I../libmyth -I..
-Idvbdev -Impeg -I../libavcodec -I../libmythmpeg2
-I/usr/lib64/qt-3.3/include -o osdsurface.o osdsurface.cpp
{standard input}: Assembler messages:
{standard input}:56: Error: suffix or operands invalid for `pop'
{standard input}:59: Error: suffix or operands invalid for `push'
{standard input}:62: Error: suffix or operands invalid for `pop'

Jay

>On Mon, 2005-04-25 at 23:25 -0400, Jay Merrifield wrote:
>> Hey, I ran across a weird problem with the denoise function and
>> AthlonXP. AthlonXP registers as a MMX capable processor, but in the
>> filter_denoise3d.c function, it has #ifdef i386 which isn't being
>> triggered for my cpu, but when the NewDenoise3dFilter() function gets
>> called, it checks the MMX flag, which calls denoiseMMX which is now an
>> empty function (see line 424, 425) so the denoise filter doesn't work.
>> A simple solution would be to have the MMX function call teh denoise
>> function, but a better solution would be to have some athlon specific
>> optimizations (which I lack the specific knowledge). Any thoughts?
>
>Can you try again with CVS, you need to rerun./configure
>after you update.

>-- Daniel