[mythtv] Re: [PATCH] mythtv player bookmarks for external files

Isaac Richards ijr at case.edu
Sun Apr 10 05:29:00 UTC 2005


On Wednesday 06 April 2005 10:58 pm, Peter Marriott wrote:
> > I have created a patch that enables the mythtv player to save
> > bookmarks to the database when it is used to play external files.
> >
> > I have mythvideo setup to use mythtv as its player.  With this patch I
> > can now use  bookmarks along with all the other cool features of the
> > mythtv player. ( I especially like using the timestretch.)
> >
> > The patch involves adding a new table to store these bookmarks.  I
> > considered using the videometadata table, but this wouldn't work in my
> > case as I just use the "file browser" type mode of mythvideo.
> >
> > I'd appreciate any feedback.... My first patch, so hopefully I
> > followed standards correctly.
>
> Any chance this could be include in 0.18?  If not any suggestions on
> how I could change it so it would be accepted?   Sorry if I am just
> being too impatient :)

I've applied this, fixed it to use isVideo instead of title.isEmpty, and fixed 
the db update to not crash when run.

Isaac


More information about the mythtv-dev mailing list