[mythtv] [PATCH] audiooutputalsa.cpp Broken pipe fix
Isaac Richards
ijr at po.cwru.edu
Tue Sep 7 00:07:58 EDT 2004
On Monday 06 September 2004 03:43 pm, David George wrote:
> Here is a patch to properly handle broken pipes. Mostly based on the
> oss emulation library in the alsa project itself. See the
> lib_oss_pcm_write function at:
> http://cvs.sourceforge.net/viewcvs.py/alsa/alsa-oss/alsa/pcm.c?rev=1.3
> for more info.
Applied.
> I also added a sample Doxygen comment before SetParameters so we could
> see what it would look like. This is based on examples I have seen. I
> am not a Doxygen expert.
This is exactly what I _don't_ want. Functions should be documented as to
what they do, not wasting space describing what the variables are. If that's
not clear from the type and name, then that needs fixed, not extra
documentation added.
Isaac
More information about the mythtv-dev
mailing list