[mythtv] [PATCH] volume control for OSS and ALSA

David George david at thegeorges.us
Tue Oct 26 16:41:44 UTC 2004


On 10/26/2004 11:14 AM, Isaac Richards wrote:

>Why didn't you make it part of the audiooutput class?
>  
>
Honest answer?  Because I had problems figuring how to do it without 
breaking tv_play.cpp and mythmusic. :-)

More detailed answer is because I already had this written before the 
big audio update was posted and it worked well enough for me.  I was 
working on getting the volume control into the audio output class, but 
one of my biggest stumbling blocks was to get it into Mythmusic as 
Mythmusic uses libs/libmyth for volume routines, but has its own 
audiooutput class.  Doing the volume control this way there are only a 
couple of very small changes to tv_play and playbackbox.

This isn't anything that needs to go into CVS unless you want to.  I was 
just getting it out there for anyone that wants to pick up the torch.  I 
know that Ed is also working on integrating these volume control changes 
into the audio output classes, but at this point it is a little beyond 
my time to figure it out and work on it.  While my C skills are very 
strong my C++/QT skills aren't (I can read it, I can write it, but I 
can't necessarily design it yet... ).
--
David

P.S.  For others that may not have looked at the code.  Yes, I know that 
Mythmusic only supports OSS, but it calls libmyth's volume control 
routines so it needed to be modified for the new calling convention.



More information about the mythtv-dev mailing list