[mythtv] [PATCH] AvFmtDec defaults?

[Kenneth Aafløy]

On Saturday 23 October 2004 19:53, Daniel Thor Kristjansson wrote:
> I see what you are saying. The reason I think it's safe is that there
> are two ways ScanStreams gets triggered. One is that ffmpeg has looked
> at the file extension and first 32k of the stream and determined the
> stream types. I'm assuming this process never leaves the codec set to
> zero, that kind of bug should have been shaken out by now. The other way
> that ScanStreams is triggered is from the PMT in a TS stream. If the
> stream type of a pid doesn't change from the initial scan there
> shouldn't be any problems, so any streams created by a transcoder (such
> as MPEG4 in TS) should be ok. But we can't trust broadcast streams,
> which may change a video pid to an audio pid on a channel change.
> Hopefully my changes will work, but I may have missed some case, so I
> left in this failsafe.

Ok, I've attached a patch that makes it an assertion, since that is what we 
assume is the case from a libavformat viewpoint, right?

> I don't know, right now I think we should only open the player if video
> and audio is present. But at some point I think we should open a player
> if either is present, and perhaps even if teletext only is open. (Say
> Myth is used in a CCD system with no sound, or a 'radio over cable'
> application, or a teletext for the blind application..)

Agreed.

I've made a simple fix for a problem with selecting a new audio stream if the 
current dissapears. This rescanning could be made much smarter if we could 
assume that all current streams will have the same id after rescanning.

I'll see if it's a simple fix to make it possible to only have audio or video 
next.

> ]Or I play back a transport stream with an unknown mpeg extension like the
> ]mpeg4 in ts.
>
> It should work now because of the 32k initial scan, I'd love it if you
> tested that theory though ;)

Um ;)

Kenneth
-------------- next part --------------
A non-text attachment was scrubbed...
Name: avfd.patch
Type: text/x-diff
Size: 2219 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20041023/25281d2d/avfd.bin