[mythtv] Audio Update - Another patch
Ed Wildgoose
lists at wildgooses.com
Sat Oct 23 13:54:37 UTC 2004
> Thanks! Getting some problems here:
Ooops, yes. Spot on. Forgot that file. See attached patch:
> If you mean my little Alsa patch, it is *not* included in your
> patch/files. It's attached to this e-mail in case you lost it or if
> someone else would like to take a look at it.
OK, thanks, got it. Will apply it. But a few questions first:
>+ if (pcm_handle == NULL)
>+ {
>+ VERBOSE(VB_IMPORTANT, QString("WriteAudio() called with pcm_handle == NULL!"));
>+ return;
>+ }
>+
>
>
Is this stuff really needed now if we never close the device? No point
having redundant code cluttering up the place? How would we ever have a
null handle now?
>+ // CloseDevice();
>
>
Why do we need this comment? Can we remove this line now?
Thanks for your patch. I assume you can put these two bits together
yourself though without me resubmitting the whole thing? (Just for testing)
Any other comments?
Ed W
-------------- next part --------------
Index: programs/mythtranscode/transcode.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/programs/mythtranscode/transcode.cpp,v
retrieving revision 1.10
diff -u -r1.10 transcode.cpp
--- programs/mythtranscode/transcode.cpp 13 Oct 2004 01:49:55 -0000 1.10
+++ programs/mythtranscode/transcode.cpp 23 Oct 2004 13:50:21 -0000
@@ -129,6 +129,21 @@
return last_audiotime;
}
+ virtual int GetVolumeChannel(int channel)
+ {
+ // Do nothing
+ return 100;
+ }
+ virtual void SetVolumeChannel(int channel, int volume)
+ {
+ // Do nothing
+ }
+ virtual void SetVolumeAll(int volume)
+ {
+ // Do nothing
+ }
+
+
int bufsize;
unsigned char *audiobuffer;
int audiobuffer_len, channels, bits, bytes_per_sample, eff_audiorate;
More information about the mythtv-dev
mailing list