[mythtv] [PATCH] Reinitialize deinterlace filter on video change
J. Donavan Stanley
jdonavan at jdonavan.net
Fri Oct 22 10:07:36 UTC 2004
Doug Larrick wrote:
> Isaac Richards wrote:
>
>> Doug, was it ever determined why this patch didn't work properly for
>> some people? The deinterlace filters do need reinitialized on size
>> changes, somewhere..
>
>
> I think it was more that it didn't fix some unrelated problems people
> were seeing. The patch is absolutely necessary if the video ever
> changes back and forth from progressive to interlaced scan, which it can
> when changing HDTV channels in Live TV.
>
>> Also, I think the current code may leak, if
>> videoOutput->SetupDeinterlace(true) is called twice in a row, no?
>
>
> I actually don't think so, because if m_deinterlace is already true, it
> bails out early. But with the attached patch it's probably less fragile
> to future changes.
Committed to CVS thanks.
More information about the mythtv-dev
mailing list