[mythtv] [PATCH] Re: videooutbase: Zoom won't go to edges

Chris Pinkham cpinkham at bc2va.org
Fri Oct 15 19:42:53 UTC 2004


> I didn't see any response to this item, and I forgot to put [PATCH] in 
> the subject line, so I'm reposting this in case it got overlooked.
> 
> Thanks,
> Jeremiah
> 
> On 9 Oct 2004, at 4:13 PM, Jeremiah Morris wrote:
> 
> > After experimenting with the manual zoom functions in playback, I 
> > found that the arrow keys won't allow one to reach the edges of the 
> > zoomed image.  I tracked this down to videooutbase.cpp; the left/right 
> > and up/down variables are treated as a range from -100 to 100, but 
> > they only actually reach from -90 to 90.
> >
> > I couldn't find documentation of a reason for this, the attached patch 
> > fixes the problem.  If there is a reason -100 and 100 were disabled, 
> > perhaps I can help find another way to solve the problem.
> >
> > - Jeremiah

Sorry, I saved the email and meant to reply but forgot to do so.  I think the
90 vs 100 was just a limit I pulled out of my hat when I wrote that code.  I
don't think there's any reason not to allow the full 100, so I'll get this
in when I commit my tree to CVS next.

Thanks for reminding me.

-- 

Chris



More information about the mythtv-dev mailing list