[mythtv] Re: compiling mythtv frontend for cygwin
Isaac Richards
ijr at po.cwru.edu
Thu Oct 14 04:35:51 UTC 2004
On Tuesday 12 October 2004 10:51 am, Geoffrey Hausheer wrote:
> On Tue, 12 Oct 2004 03:47:43 -0500, Mario L wrote:
> > .... If that patch could get applied to CVS by someone, then
> > some other people can finally join in on this since it is basically
> > down to a science.
>
> While Isaac is probably the only one with a say in whether something
> like this goes in, I wouldn't count on it. First off, there is no
> reason to put it into the code yet, as it doesn't work. Anyone
> competent enough to do hacking on it can install your patch and make
> new ones. Second the code will be nearly impossible to maintain.
> There are ifdefs all over the place. The ones controlling headers I
> can understand, but there are many others. Since almost all of the
> developers run Linux, they don't want to worry about whether they are
> breaking the win32 build, and I would guess that Isaac doesn't want to
> have to wait for the win32 maintainers to fix bugs before releasing
> new versions. I would say (a) get it working first. I don't see nay
> compelling reason to add it otherwise, and (b) after you do that,
> clean up the patch to minimize differences such that the maintenance
> will be easier.
>
> As an aside, if you want unix people to look at your patches .tar.bz2
> (or .gz) is a much better format that rar. I hate having to use
> proprietary programs to just look at a patch. And again anyone
> familiar with cygwin will know how to use tar, so you aren't
> alienating your users.
I agree with all this - there is too much cruft in the patch that should be
slimmed down by quite a bit before I'd consider applying it.
Isaac
More information about the mythtv-dev
mailing list