[mythtv] [PATCH] Big audio update redux

Ed Wildgoose lists at wildgooses.com
Wed Oct 13 16:37:51 UTC 2004


David George wrote:

> On 10/11/2004 6:54 AM, Ed Wildgoose wrote:
>
>> Ed Wildgoose wrote:
>>
>> Hi, Thanks for the volume control stuff.  I think we need to think 
>> multichannel and break out the interface a little.  Could you please 
>> revisit this patch with the following changes:
>>
>> - Move the interface functions in AudioOutputBase into AudioOutput 
>> (so they have to be implemented everywhere).
>> - AudioOutput functions should be simply: "SetVolume(int channel, int 
>> volume)", "SetVolumeAll(int volume)", and "GetVolume(int channel, int 
>> volume)".  Everything else is implemented using those
>> - Keep the volumecontrol.h/.cpp and do all the clever stuff here.  
>> Make this class inherited by NuppelVideo or whatever it is, so that 
>> the functionality is exposed as public functions that are available 
>> to the frontend player application.  Now we can implement our invert 
>> muted channels code and stuff like this here.  However, make the 
>> setvolume calls use the SetVolumeAll code and this way a multichannel 
>> output will also be controlled in the same way
>>
>> I have a patch with all the other stuff apart from this in, and just 
>> testing it now.  Will submit for CVS shortly
>
>
> Thanks for looking at this.  There isn't much more I can do on the 
> volume control code right now.  I did have the sound-system 
> independent volume control working previous to the "big audio update" 
> and the actual ALSA specific code should work so if someone could 
> write the above mentioned parts we should be in good shape WRT the 
> volume control.  (And of course the actual OSS specific code already 
> works except that it was disabled in my patch.)


I submitted my patches to Isaac a couple of days back.  It seems to take 
a little time to get stuff committed, but when that is in, and I have 
put my living room floor back together, then I can probably finish this 
off for you.  Can you help out with the frontend settings changes though?

Give me a few days and I will sketch out the rough framework and then we 
can work on the details like the settings interface afterwards

Thanks for this

Ed W


More information about the mythtv-dev mailing list