[mythtv] Possible errors
Isaac Richards
ijr at po.cwru.edu
Fri Oct 8 18:23:59 UTC 2004
On Friday 08 October 2004 01:58 pm, marty.boeckman at comcast.net wrote:
> The code below has a note about being slow. It could be fixed by putting a
> break statement in the loop whenever the boolean is set to false. Because
> once the boolean is set to false, that's all this method can ever return.
> I found this potential issue using a case tools audit feature. The results
> of the audit are posted at:
> http://home.comcast.net/~marty.boeckman/audit.txt
The main issue with it being slow is the use of at(), which iterates linearly
through the list for each item. Fixing that would bring about a much better
fix than simply breaking out of the loop.
Isaac
More information about the mythtv-dev
mailing list