[mythtv] [patch] Fix for sluggish pause
Isaac Richards
ijr at case.edu
Tue Nov 30 04:02:57 UTC 2004
On Monday 29 November 2004 10:10 pm, David Engel wrote:
> On Mon, Nov 29, 2004 at 08:28:35PM -0500, Doug Larrick wrote:
> > The attached patch fixes this problem. It causes the decoder thread to
> > release the decoder lock while waiting for an available video buffer.
> > Not the prettiest way to shoehorn this in here, but at least it gets the
> > job done and is unlikely to break in unforseen ways.
>
> This patch won't be going in. The purpose of the lock is to ensure
> speed changes only occur when the lock is not held by the decoder
> thread and this change defeats that.
I think that it looks ok for the software decoding case, if the unlock were
moved into the !EnoughFreeFrames() clause - it's just dropping the lock when
idle and waiting on a free frame, and there's way too many things calling
GetFrame() to easily break out of the function and try again.
Isaac
More information about the mythtv-dev
mailing list