[mythtv] [patch] Fix for sluggish pause
Doug Larrick
doug at ties.org
Tue Nov 30 03:40:49 UTC 2004
David Engel wrote:
> On Mon, Nov 29, 2004 at 08:28:35PM -0500, Doug Larrick wrote:
>
>>The attached patch fixes this problem. It causes the decoder thread to
>>release the decoder lock while waiting for an available video buffer.
>>Not the prettiest way to shoehorn this in here, but at least it gets the
>>job done and is unlikely to break in unforseen ways.
>
>
> This patch won't be going in. The purpose of the lock is to ensure
> speed changes only occur when the lock is not held by the decoder
> thread and this change defeats that.
>
> The proper fix is to have NVP::GetFrame return early when it can't get
> a free buffer after a small amount of time. Be sure to update the
> ivtv decoder for the skipping frames case because it works
> differently. Also leave some kind of check to inform the user when
> the buffer queue really does get stuck.
Somebody who understands the issue here will have to have a try, then.
Whatever the fix is should make sure the lock isn't held 99% of the
time, though.
-Doug
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20041129/f96f7d19/signature.pgp
More information about the mythtv-dev
mailing list