[mythtv] [patch] Fix for sluggish pause

David Engel gigem at comcast.net
Tue Nov 30 03:10:41 UTC 2004


On Mon, Nov 29, 2004 at 08:28:35PM -0500, Doug Larrick wrote:
> The attached patch fixes this problem.  It causes the decoder thread to 
> release the decoder lock while waiting for an available video buffer. 
> Not the prettiest way to shoehorn this in here, but at least it gets the 
> job done and is unlikely to break in unforseen ways.

This patch won't be going in.  The purpose of the lock is to ensure
speed changes only occur when the lock is not held by the decoder
thread and this change defeats that.

The proper fix is to have NVP::GetFrame return early when it can't get
a free buffer after a small amount of time.  Be sure to update the
ivtv decoder for the skipping frames case because it works
differently.  Also leave some kind of check to inform the user when
the buffer queue really does get stuck.

David
-- 
David Engel
gigem at comcast.net


More information about the mythtv-dev mailing list