[mythtv] [PATCH] Alsa audio sync and other fixes for latest big audio update

David George david at thegeorges.us
Fri Nov 5 11:38:20 UTC 2004


On 11/05/2004 05:10 AM, Ed Wildgoose wrote:

> David George wrote:
>
>> Ed,
>>
>> Here is a patch against your latest posted audio update.  I took a 
>> clean checkout of mythtv as of Nov 2 and applied your audio patch to it.
>>
>> This is a diff -Nura against it.
>
> Excellent.  Thanks for this.  I will apply it against my tree shortly 
> and test it.
>
> Isaac.  In principle are you happy to take the two seperate patches 
> and apply to CVS now, or would you prefer a single patch?
>
> David, one quick question: What's with the "audio_buffer_unused" 
> variable, where you deduct a couple of buffers worth of space from the 
> actual buffer size?  In my case, my card only has two audio buffers 
> for example - how does this affect me?  I have never really understood 
> the point of this bit of code really?

This makes the soundcard buffer look smaller than it is.  It is used by 
"enable aggresive sound card buffer".  Not sure why it is used as any 
time I have tried it audio problems got worse, but I remember seeing 
messages about the aggressive buffering in the archives.

> I would also quite like some more eyes on my code around the "effdsp" 
> variable.  It's only going to make a tiny difference, but in the case 
> of resampling I can't quite decide if the current cvs code *really* is 
> correct? (I think it is..)

I'll have to look tonight after I get home from work.

--
David



More information about the mythtv-dev mailing list