ATTN Isaac: Re: [mythtv] [PATCH][Discussion]Supporting frequencies nexttofreqid'sin MythTV

[Paul Koster]

Isaac (or any other developer),

Below I've included an Email send to this list some months ago that never
got a reply.

There are two issues with Myth supporting frequencies:
- the 'freqid' column of the channel table has type varchar(5) it seems.
This should become varchar(6) to support 100MHz = 1000000kHz and up.
- the code takes into account finetuning while this is not necessary (as
described below, because the resolution is already high enough).

Kind regards,
Paul

From: "Isaac Richards" <ijr at po.cwru.edu>
> Thanks, applied this, though I changed the logic somewhat, as I believe
you
> broke normal operation.

Indeed it seems that I could have been off with a factor 16 in the
old/normal case indeed. I wanted to ensure that TuneToFrequency would get
frequencies in kHz and changed TuneTo accordingly, because frequencies
expressed in kHz*16 are confusing and should preferably not be used accross
functions. I now notice that this can't be done in a trivial way without
introducing rounding errors.

You changed the parameter that is passed to TuneToFrequency:
   frequency = frequency * 16 / 1000 + finetune;
Why do you take into account 'finetune'? Frequency can be entered with a
higher resolution (steps of 1kHz) then finetune can offer (62.5kHz, and they
work on total different scales) so finetune could be left out.

--
Paul

_______________________________________________
mythtv-dev mailing list
mythtv-dev at mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev