[mythtv] [PATCH] mythvideo cd support

[J. Donavan Stanley]

Xavier Hervy wrote:

> What does this patch ?
>
> mediamonitor_iso9660.diff add volumeid and keyid for iso cd and change
> mediahandler to allow it to send MythMediaDevice.
>
> for mythvideo:
> mythvideocdsupport.diff + 2 files videoutils.cpp and .h
> This patch do a lot of thing
> + allow browsing cd
> + add cd in database collection (add a table called videostorage)
> + videotree,videogallery and videobrowse take care about the browse flag
> (in VideoFilterSettings class)
> + add last time seen flag, each time you watch a movie the lastseen =
> curdate ( in videometadata new fields lastseen)
> + change menu in videogallery by a menu in tree that allow to filter
> list and group by some fields (instead of filepath)
> + move all code for playing a video in videoplayer class (in
> videoutils.h & .cpp)
> + in videomanager if the imdb is 00000000 and you press select, the
> movie is search on internet (imdb / allocine) instead of open
> editmetadata dialog)
> + add code in metadata.h and .cpp, to manage storage (videostorage)
>

Just from skimming the patches without applying them a few things jump 
out at me:

1)  The change to the SELECT behavior  shouldn't be there.  This way 
we're consistent in what it does and we have zero impact from 
accidentally hitting SELECT on the wrong video.
2) What's with the:  "system("mysql mythconverg -e \"s" stuff
3) This patch removes a lot of the utf8 stuff...
4) You're using the amount of time the file has been playing to 
determine if it's been seen.  Problem is, what if I pause the video then 
exit from it?  It's better to say "if it's played it's watched" then try 
to guess by using the amount of time the player has been active.
5) There's a lot of commented code here.
6) One should never be able to show a video in browse mode that doesn't 
have it's browse flag active.  There should be no way to toggle the 
browse flag of a video without passing through the video manager.  That 
means browse shouldn't be a filter criteria...