[mythtv] [PATCH] MediaMonitor data and MythVideo support

Matt Porter mporter at kernel.crashing.org
Tue Jun 29 11:50:00 EDT 2004


On Tue, Jun 29, 2004 at 09:56:22AM +0200, Xavier Hervy wrote:
> Hi Matt,
> I take a look on the both patch but i try them.
> First, Iimade a lot of change in mythvideo, that include cd collections 
> in. then i think your clean code for mythvideo isn't appropriate now. 
> sorry ;-)

I haven't seen the patches posted anywhere. :) My hope is that we
can at least get this base patch in and then the enhanced support
can be built upon it. I have some areas I'd like to tackle away
from the actual mythvideo useage you are working on (mythmusic
mp3 cdrom and mythgallery hotplug image data support).

So, as I mentioned hopefully this serves as a working base and
you could add your cd collections support on top of it.

> for the second patch, i just wake up, then my brain don't run normally. 
> I don't see the difference betwen you patch and mine. i made a diff -u 
> between the both patch but the result is rubbish. ;-)
> Can you tell me what exactly you change ?

You tried to diff a patch?  That's not very good...if you really want
to "diff" a patch you have to use something like patchdiff that's
designed to show the differences. Anyway, here's the cleanups from
your mythvideo patch to mine:

* Remove the unrequired #include changes
* Minor output format change
* Remove dangling commented code from VideoTree
* Remove unused GetMountPoints from VideoTree

> Because i add in my mediamonitor the capability to ask the volumename 
> and keyid for each cd in iso9660 and udf.

That can be added to the media monitor with an accompanying patch
that uses it.  I just wanted something compact/clean that worked
to jump to mythvideo and play movies from optical media. 

> What i don't understand in your patch is the include in mythcontext.h
> +#include <mythtv/mythmediamonitor.h>
> +#include <mythtv/mythmedia.h>
> instead of
> +#include <mythmediamonitor.h>
> +#include <mythmedia.h>
> If you make a fresh install
> mythtv/mythmediamonitor.h and mythtv/mythmedia.h don't exist, no ?
> if it works, can you explain why ? (and we don't need to change all .pro 
> file for each plugin :))

Ah, yes. I had to clear out my /usr/local/include/mythtv. :)
After a discussion on IRC, Isaac suggested that we can avoid
all this by reworking it into a singleton class.  This will
eliminate all the mythcontext pollution...more good cleanups.
I'll probably post another couple patches sometime tonight.

-Matt


More information about the mythtv-dev mailing list