PATCH: Re: [mythtv] Segfault + BT: Race condition in filtermanager

Isaac Richards ijr at po.cwru.edu
Fri Jun 25 19:32:05 EDT 2004


On Friday 25 June 2004 08:05 am, Ed Wildgoose wrote:
> Ed Wildgoose wrote:
> > I'm still trying to track down the segfault that I repeatedly see when
> > video changes aspect ratio from 4:3 to 16:9.  At last with the latest
> > GDB I seem to be able to get a clean backtrace, and as you can see it
> > rather seems to point to something happening in the video playback
> > loop before the filter manager manages to get everything reinitialised
> > in ReInitVideo
>
> Aha, a lightbulb goes on.  I was misled by where GDB seemed to be
> telling me where the segfault was.  The filter variable is not locked
> and used by two threads.  The attached patch fixes this for me.
>
> What's pecualiar is why no one else has seen this?  It should have been
> hitting a lot of people really?

Well, aspect ratio only changes for people with DVB and the pcHDTV cards, 
which should be a comparatively small number.

> Please apply to cvs

Yup, it's in.

Isaac


More information about the mythtv-dev mailing list