[mythtv] [PATCH] Album Artist support for MythMusic (good for
soundtracks/compilations etc.)
Kenneth Aafløy
ke-aa at frisurf.no
Wed Jun 23 18:20:34 EDT 2004
On Wednesday 23 June 2004 23:50, Colin Guthrie wrote:
> Sorry not posted before and I just realised that I didn't bz2 my patch
> so it's a little large for a list.
Nah, it wasn't big enough to trigger the limit, and Isaac always brags about
his bandwidth, so let's test it, right? ;)
> Apologies, won't happen again guv'nor. Honest!
>
> Is it better practice to u/l potential patches to a URL?
Only if they are huge, and have no relation to most parts of the list or
something?
I must say this is a nice idea, as I've been using the Tree sorting:
directory, because I have a lot of collection albums :)
But I don't get excactly how I'm going to automatically put all my compilation
albums with id31 into MythMusic. I'm I supposed to rename artist to 'Various
Artists - <Real Artist>'? At least that is what I got out of a quick read,
and does not sound good for id31, because of limiting artist name length?
I belive, but it's not up to me, that your patch is very clean, but contains a
lot of self reffering comments, what about naming the functions/members in a
way that they won't need commenting? I also got stumped when you added a
member and suddenly broke naming convention clearly stated right above it
(mBlnAlbumArtistMod).
I'm staying with my directory tree sort setup for now, untill a clean method
of extracting multi artist compilations is clarified.
My 2 cents.
Kenneth
More information about the mythtv-dev
mailing list