[mythtv] [PATCH] MythVideo & Mediamonitoring (suite)

Xavier Hervy maxpower44 at tiscali.fr
Wed Jun 16 09:06:07 EDT 2004


Hi Leao,
thx to try this patch :)

Leo Weppelman wrote:
> Xavier,
> 
> On Sun, Jun 13, 2004 at 06:57:50PM +0200, Xavier Hervy wrote:
> 
>>Ok i send to patch the first is for mythtv :
>>- fix bug about lock drive
>>- get volumeid from iso9660
> 
> 
> I have been playing with these 2 patches a little. Inserted is a dvd
> with a movie (UNBREAKABLE).
> With your patches I see the following:
>   2004-06-16 13:54:59 mythfrontend version: 0.15.20040528-1 www.mythtv.org
>   2004-06-16 13:54:59 Enabled verbose msgs : important general
>   2004-06-16 13:55:06 Registering Internal as a media playback plugin.
>   2004-06-16 13:55:06 Registering MythDVD DVD Media Handler as a media handler
>   2004-06-16 13:55:06 Registering MythDVD VCD Media Handler as a media handler
>   2004-06-16 13:55:07 Registering MythVideo CD/DVD DATA Media Handler as a
>                       media handler
>   2004-06-16 13:55:10 Mediamonitor: Adding /dev/cdrom
>   2004-06-16 13:55:10 Starting media monitor.
>   2004-06-16 13:57:04 Media status changed...  New status is: MEDIASTAT_OPEN
>                       old status was MEDIASTAT_NOTMOUNTED
>   VolumeID UNBREAKABLE                     
>   2004-06-16 13:57:25 Executing '/bin/mount /dev/cdrom'
>   mount: /dev/cdrom already mounted or /cdrom busy
>   2004-06-16 13:57:25 Failed to /bin/mount /dev/cdrom.
>   2004-06-16 13:57:25 Media status changed...  New status is:
>                       MEDIASTAT_NOTMOUNTED old status was MEDIASTAT_OPEN
> 
> So, the VolumeID is OK. But the mount fails. I saw that your patch 
> removes the close at the start of MythMediaDevice::performMountCmd().
> When I put that back, the mount succeeds...

Thx to try this patch :)
I remove the close at the start of MythMediaDevice because when i made 
my test, i made 3 observations :
- I can mount a drive even if the device is open
- I can't unmout drive if the device is open
- i can't open device if the device is mounted.

see this thread for more information : 
http://www.gossamer-threads.com/lists/mythtv/dev/71755
Can you explicitly make the test which is describe in the post ?
it's why i remove the close at the beginning, if i close it, 
mediamonitor can't open the device to check the status.
But i can make a mistake then i will try again and send feedback


> 
> There is another nit I'd like to make to the media handler. On the inserted
> DVD, the directory '/video_ts' is all in lowercase while the mediahandler
> expects it in uppercase. I suspect that difference is caused by the way
> the dvd is created. Can you (or someone else) check if I am the only one
> seeing this? The following patch accepts both:
I don't have dvd like this but we can add this without trouble ....

I will try it just to verify it don't break "normal" dvd.

Xavier



More information about the mythtv-dev mailing list