[mythtv] TOGGLEFAV problem

David Engel gigem at comcast.net
Fri Jun 4 01:10:24 EDT 2004


I finally got around to looking into why TOGGLEFAV doesn't work
anymore.  The culprit appears to be TranslateKeyNum() which ors the
modifier values into the returned keynum.  This causes ? to be turned
into Qt::SHIFT+? and TranslateKeyPress() then doesn't match it to
anything in the keybindings table.

I tested by not having TranslateKeyNum use the shift modifier and,
sure enough, TOGGLEFAV started working again.  I'm not going to commit
this change because it would break the use of shift with other keys
like left, right, etc.  I think a reasonable fix is to ignore the
shfit modifier if the key is an ASCII key (0x00 - 0x7f).

Isaac, what do you think?  You know the impact of any change there a
lot better than I do.

David
-- 
David Engel
gigem at comcast.net


More information about the mythtv-dev mailing list