[mythtv] Mac OS X patch 2
Nigel Pearson
nigel at ind.tansu.com.au
Wed Jun 2 03:43:29 EDT 2004
> emms() should be defined as an empty macro on non-i386. If you could
> find
> out where that isn't happening and patch it there, that would be much
> better
> than #ifdefing every occurrence of emms().
Agreed, although adjust/filter_adjust.c has a big #ifdef i386 block
and no definition for emms()
...
> There is an i386 definition for mm_support(), and a non-i386 one. The
> non-i386 one looks like this:
>
> int mm_support(void) { return 0; }
Yes, and other filters (e.g. linearblend/filter_linearblend.c)
do this sort of thing for emms() too. Here is a better patch.
% cvs diff -u filters >../patch.macosx.7
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.macosx.7
Type: application/octet-stream
Size: 1015 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20040602/25e3c217/patch.macosx.obj
-------------- next part --------------
...
> I'm just letting you know what needs to happen in order to get this
> merged.
> I want to avoid breaking or setting back other ports by merging new
> stuff.
Sure. Sorry if I seem argumentative or impatient.
It is just that I am a little impatient ;-)
--
Nigel Pearson, nigel at ind.tansu.com.au | "Now the world has gone to bed,
Telstra BI&D, Sydney, Australia | Darkness won't engulf my head,
Office: 8255 4222 Fax: 8255 3153 | I can see by infrared,
Mobile: 0408 664435 Home: 9792 6998 | How I hate the night." -Marvin
More information about the mythtv-dev
mailing list