[mythtv] [PATCH] abstract IMDB queries into external scripts

[Tim Harvey]

> -----Original Message-----
> From: mythtv-dev-bounces at mythtv.org
[mailto:mythtv-dev-bounces at mythtv.org]
> On Behalf Of Isaac Richards
> Sent: Friday, January 30, 2004 12:42 AM
> To: Development of mythtv
> Subject: Re: [mythtv] [PATCH] abstract IMDB queries into external
scripts
> 
> On Thursday 29 January 2004 02:33 am, Tim Harvey wrote:
> > Ok, here's my followup patch:
> >
> > Installation:
> >
> >    I still can't figure out how to include 'new' files in a patch.
The
> > suggestions posted in this thread did not work for me (cvs add
fails,
> > and hacking my local dir to 'think' there is a CVS entry just tells
me
> > it can't find the prev rev in CVS to diff against).  Therefore
you'll
> > have to extract the contents of the 'scripts.tgz' in the
> > mythvideo/mythvideo directory.  The Makefile will be looking for
files
> > in that directory.  Apparently my last patch had something wrong
with
> > the binary I uploaded (last byte was left off!?).  I'm not sure what
> > caused this, but please let me know if there is something wrong with
> > this one as well.
> 
> Well, I _was_ going to apply this, but there's a few problems.  First
off,
> the
> options parsing in the script didn't work for me (attached imdb.pl
fixes
> it

Sorry about that.  I haven't written any perl in 10 years so I'm real
rusty with it.  I was using the option parsing from some examples I
found.  I don't quite understand why it worked for me and not you, but
if its fixed, thanks!

> for running on the command line, thanks to mdz).  Secondly, I don't
think
> this deals with titles with spaces in it at all, and it may also need
to
> quote the args to -M (need to on the command line, at least).  I'm not
> getting anything back from the QProcess, at least.

Yes, it deals with filenames with spaces fine.  You can add args to a
QProcess without worrying about that.  I tested it with quite a few
movies in my selection (most of which have spaces in their filenames).

It must be something else that's causing you problems.  I haven't heard
any feedback from anyone else.  If you run the frontend with a -v you
should see the commandline (granted, the commandline you see can't be
cut-n-pasted to the shell without putting quotes around the filename and
escaping any semicolons in the options parameter).  Verbose mode should
also show you the output of imdb.pl.  From that I should be able to tell
what's going on.

You can also try to run the script manually, and/or add a '-d' in the
command line to see debug output.

I've gotten feedback from at least one other person that's tried the
patch and the lookups were working fine for them.  Other than that, I
haven't heard any positive or negative feedback.

Tim

> 
> Isaac