[mythtv] Re: [mythtv-commits] mythtv commits

[Steve Davies]

David Engel wrote:
> On Wed, Jan 21, 2004 at 09:42:53AM -0000, Steve Davies wrote:
> 
>>Is there a reason for the recent change to the IsSameProgramTimeslot
>>method in programinfo? I find it is too "loose" now, and has the habit of
>>matching too much.
> 
> Yes.  The check was loosened in order to catch the state changes for
> stopped and deleted recordings.  Those changes originate from data
> obtained from the record table, which doesn't save the sourceid or the
> original startts and endts.

Yes, I just looked at the new behaviour, and it does look right for this 
scenario. Sorry, I misinterpreted it a little.

>>I'm probably missing something, but I have made use of the old behaviour
>>in a patch I'm putting together, and the change broke things for me. Can I
>>put this back, or shall I define a separate "IsExactSameProgramTimeslot"
>>method?
> 
> How/why does it break?  If you can't use the existing check, then
> please create a new one.
> 
> David

I have a new mode where XmltvId can be used to recognise common channels 
across different sources. Ideal for me where I have one terrestrial analogue, 
one DVB-T and one cable source, all with different but overlapping channels. 
To achieve this I used the existing matching code - I'll implement an 
alternative which does an exact-timeslot match.

The patch also fixes up some common scheduler omissions which I've seen 
mentioned on the list.

Perhaps I should send you the (updated) patch off-list for approval?

Steve
-- 
Steve Davies                   steve at one47.co.uk

PGP Fingerprints:
DH/DSS : 5D85 8164 91D7 E9CC 4F80  842B AB86 93D9 8938 7612
RSA    :      4E2E E60F 3D76 9E7E  70F9 901B 70FA 56C8
RSA4096: 02BE 5C0E EFA2 E1E4 EA89  C9CC 1E4F F654 3BC7 B65E