[mythtv] [Patch] Commercial free flag for channels

J. Donavan Stanley jdonavan at jdonavan.net
Tue Jan 20 05:11:42 EST 2004


Matt Zimmerman wrote:

>On Mon, Jan 19, 2004 at 09:59:49PM -0500, J. Donavan Stanley wrote:
>
>  
>
>>+        const QString updates[] = {
>>+	    QString("ALTER TABLE channel ADD COLUMN commfree TINYINT NOT NULL default '0';"),
>>+	    QString("ALTER TABLE record  ADD COLUMN commflag TINYINT NOT NULL default '0';"),
>>    
>>
>
>This looks mostly sane, but what's commflag for?  It doesn't seem to be used
>by your other changes.
>
>  
>
The nest phase of this I'm going to make it so that commercial flagging 
can be overridden on a per show basis.  That folks who watch CSI and 
other shows comm flagging have troubles with can turn it off in the 
advanced recording options screen.

>>+    progMap["commfreee"] = chancommfree;
>>    
>>
>
>Also, isn't this one too many 'e's?
>  
>

Yeah it is.

>  
>
>>+    int chancommfree;
>>    
>>
>
>Probably makes more sense as a bool, unless this is intended for something
>more generic, in which case it should probably have a different name.
>  
>
true


More information about the mythtv-dev mailing list