[mythtv] [PATCH] IMDB search fix for MythVideo
Isaac Richards
ijr at po.cwru.edu
Sun Jan 18 13:50:22 EST 2004
On Friday 16 January 2004 10:07 pm, Tim Harvey wrote:
> The attached patches fix the currently broken IMDB search in MythVideo's
> VideoManager against current CVS. This broke sometime before 0.13
> apparently.
Everything's in CVS now, thanks for updating things =)
> The problem (of course) was that IMDB changed their format again. More
> than that, they started using redirects which my previous patch added
> support for, but the patch that used the support never made it into CVS.
> No worries, because now that every search redirects I found a bug in the
> redirect logic and have fixed it (hence the httpcomms patch for
> libmyth). The patch to videomanager makes use of the redirect
> functionality in httpcomms (and I feel cleans up the code a little) plus
> handles the changes made to IMDB's information. My original patch back
> a few months ago added some more intelligent ranking to the data,
> however I haven't patched that back in because I am thinking we can
> perhaps do the queries in a more abstracted way (see below).
<snip>
> If these queries are abstracted into scripts it could be much easier to
> make them pluggable to offer different types of searches, or different
> data sources, and make them updatable by a broader group of people. I'm
> thinking perl would be nice but my perl is very rusty. There must be a
> nice perl library out there for doing http requests?
>
> Thoughts?
While I do like having things in the source instead, I do agree that it'd be
easier for people to deal with broken sites / add new ones if it were an
external script. I don't really mind what language you use, but perl would
probably be more appropriate, as it's already an indirect requirement because
of xmltv.
> Please let me know if I've submitted the patch incorrectly (or correctly
> for that matter). Its been a while and this would only be my 2nd patch.
Perfectly correct =)
Isaac
More information about the mythtv-dev
mailing list