[mythtv] [patch] hdtv signal check
Daniel Thor Kristjansson
danielk at cat.nyu.edu
Tue Feb 24 16:09:26 EST 2004
I think I had a merge problem when the SetVideoFilersForChannel() call
was added. This bit...
if (channel != NULL)
nvr->ChannelNameChanged(channel->GetCurrentName());
after "nvr->SetDB(db_conm. &db_lock);" and before
"SetVideoFiltersForChannel(channel, channel->GetCurrentName());"
seems superfluous. If (!error) is true we are already tuned to a valid
channel.
In live tv mode when say ChannelUp() is called, and if it fails we
keep going until SetChannelByString() returns successfully. Unless there
are no functioning channels this will work. (I didn't touch this code.)
-- Daniel
On Tue, 24 Feb 2004, Isaac Richards wrote:
]On Friday 20 February 2004 09:00 pm, Daniel Thor Kristjansson wrote:
]> This patch adds a signal check to TuneTo calls in the Channel class if
]> you are using HDTV. I've changed the threshold to 65% from the 70% I was
]> using before after Doug's comment about his 68% channel looking fine.
]
]I've applied the channel class part of this (to my local tree, not in CVS
]yet), but I don't really like how the tv_rec portion works -- shouldn't it be
]testing the channel when it actually sets it, not setting the channel again?
]Doesn't this ignore changing channels in live tv mode completely?
]
]Isaac
]_______________________________________________
]mythtv-dev mailing list
]mythtv-dev at mythtv.org
]http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
]
More information about the mythtv-dev
mailing list