[mythtv] problem with delete button "Yes, but record..." missing
Steve Davies
steve at one47.co.uk
Thu Feb 12 14:50:22 EST 2004
Chris Pinkham wrote:
>
> Just committed this to CVS:
>
> bool ProgramInfo::IsSameProgram(const ProgramInfo& other) const
> {
> if ((title != other.title) ||
> (dupmethod & kDupCheckNone))
> return false;
>
> if (rectype == kFindOneRecord)
> return true;
>
> if ((dupmethod & kDupCheckSub) &&
> ((subtitle == "") ||
> (subtitle != other.subtitle)))
> return false;
>
> if ((dupmethod & kDupCheckDesc) &&
> ((description == "") &&
^^^^^
Should this read "||" instead of "&&" ?
Steve
> (description != other.description)))
> return false;
>
> return true;
> }
>
> I think that's a whole lot easier to read than the previous large "if"
> statement. Appears to work correctly here, can you guys give current CVS
> a shot?
>
I agree... But the "length > 2" checks on subtitle and description are now
still in the SELECT statement in the scheduler, but not in the IsSameProgram
method. I think they should match up more closely.
Steve
--
Steve Davies steve at one47.co.uk
PGP Fingerprints:
DH/DSS : 5D85 8164 91D7 E9CC 4F80 842B AB86 93D9 8938 7612
RSA : 4E2E E60F 3D76 9E7E 70F9 901B 70FA 56C8
RSA4096: 02BE 5C0E EFA2 E1E4 EA89 C9CC 1E4F F654 3BC7 B65E
More information about the mythtv-dev
mailing list