[mythtv] [patch] libmyth patch for currupt mythepg recording menu

Isaac Richards ijr at po.cwru.edu
Tue Feb 10 16:04:14 EST 2004


On Monday 09 February 2004 01:42 pm, Simon at the Threshold wrote:
> Lo there,
>
> My first patch, this one has been irritating me since I started playing
> with mythtv at version 0.13. Basicly the description fields downloaded
> by tv_grab_uk and tv_grab_uk_rt are so that they break the create
> recording menu from the mythepg. (The recording selections are pushed
> off the bottom of the screen where they cannot be seen).
>
> The code base is large and scary so I've done a very timid change to
> mythtv/libs/libmythtv/programinfo.cpp. It truncates the strings to 512
> cahrs which means the buttons are ok no matter how long the description is.

Please look at the patch (specifically, the formatting of your code), to see 
why I won't apply this.  Additionally, if I did apply this, it has the 
potential to break duplicate detection as the truncated description would be 
written into the database at some point and then compared with the 
untruncated description if it ever comes on again.  It'd be better to limit 
the size of the displayed data, not the internal structures.

Isaac


More information about the mythtv-dev mailing list