[mythtv] [patch] NuppelVideoPlayer cleanup

[Isaac Richards]

On Wednesday 29 December 2004 04:13 pm, Daniel Thor Kristjansson wrote:
> This is the last in the series of exit cleanup patches for a while. I'm
> tackling ffmpeg next, and expect that to take some time. This is the
> biggest of the series as well, it removes premature exit()'s from the
> player and aborts the playing instead with an informational dialog for
> the user. It adds a errored variable to NVP and the videoout classes as
> well. If an error is encountered in either the NVP errored variable is
> set and the player is shut down. I think I got this right, but this
> patch needs review the most of all the cleanup patches as it's slightly
> more complex.

Something looks wonky:

@@ -1270,6 +1275,11 @@
     {
         // if we get here, we're actually going to do video output
         if (buffer)
+            if (videoOutput->IsErrored())
+            {
+                errored = killvideo = true;
+                return;
+            }
         {
             if (m_double_framerate)
                 videoOutput->PrepareFrame(buffer, kScan_Interlaced);

Also, if you're doing ffmpeg, you're going to submit the patches to them, 
right?  The more changes I have locally, the longer it takes for me to 
resync..

Isaac