[mythtv] Re: [PATCH] Add metadata editor to MythMusic

[Colin Guthrie]

Paul wrote:
> Just noticed a discrepancy in MythMusic's dbcheck.cpp which updates
> the database schema.
> 
> At the top of the file currentDatabaseVersion is set to "1001" but at the
> bottom of the file there is an update from version "1001" to "1002".
> 
> Shouldn't the currentDatabaseVersion not be set to "1002"?
> 
> If  I understand the code properly the update from version 1001 to 1002
> will never take place. If that is the case the above patch will not work
> because it uses the compilation field which is only available after the
> update to 1002.
> 
> Not sure why my database already contains the update. Possibly it was
> updated
> by the mfd stuff?

I can't really comment for why it's like that but I did notice it too.

I've added a field in my multiartist patch, but I've not yet submitted 
it as I'm still testing (the lazy way).

It is definatly to do with mfd, but I'm not sure the recommended 
practice will be.

Probably the best thing to do is to package up the dbcheck.cpp as best 
you can and alert Thor to it, as it'll probably be him that'll apply it. 
He can decide how best to number the schema... (I'm sure I asked about 
this ages ago and that was baiscally the answer given. I can't find it 
in my mail anymore, so probably archived away...)

Col.



-- 

+------------------------+
|     Colin Guthrie      |
+------------------------+
|   myth at colin.guthr.ie  |
| http://colin.guthr.ie/ |
+------------------------+