[mythtv] [RFC][PATCH] Avoiding scaling

Robert Clark mythtv at ratty.org.uk
Mon Dec 13 00:59:53 UTC 2004


On Sun, 2004-12-12 at 12:29, Ed Wildgoose wrote:

> >  I've written the patch to solve my problem, but if it's useful to
> >others, then I'd be happy to see it go into Myth. Hence the RFC: Is this
> >the right way to solve this problem?

> Really nice idea!  Like it!

  I'm just happy to finally be able to contribute something back to Myth
after reaping the benefits for so long...

> Another possible way to tackle this might be to allow resolution 
> changing as well?

  Ah. I can see in xvmc_videoout.cpp that VideoOutputXvMC::InputChanged
calls display_res->switchToVid before it calls MoveResize (where I've
added my code). I hadn't looked at what switchToVid does but, scanning
through it now, it seems to only pick a mode if it's an exact match to
the source. I guess that could be changed so it picks a "best" mode, but
I'm not sure what "best" would be here. Certainly it would make sense to
allow a fuzzy match (within 5%) if my snap patch is in use. On an
unrelated note, perhaps it should also take account of the refresh rate
for the mode?

  None of this would be useful to me at the moment (I only have one
video mode for my TV-out) but if it would help get this committed, I'm
happy to do the work if someone else can test it.

	Robert



More information about the mythtv-dev mailing list