[mythtv] [PATCH] MythMusic - Small segfault fix and efficiency

Colin Guthrie myth at colin.guthr.ie
Sat Dec 11 17:09:29 UTC 2004


Just a small patch to myth music.

It fixes a segfault in the ripping of oggs that I introduced with my 
metadata patch (sorry!). It was due to my changes to vorbisencoder and 
the use of a pointer rather than a stack member variable. I don't know 
why it was causing problems but it wasy. I took a look and there was no 
reason to do it like this, so I just changed it back to the way it was 
and pass a pointer into my function with an & prefix instead.

Also use the fdopen function rather than the silly way I was doing it in 
the metaiooggvorbiscomment.cpp file for the creation of a temporary 
file. This particular bit of code is not currently in use anyway hense 
why I didn't bother supplying the patch until I had a reason to do 
something else too!


This should be trivial if someone with cvs write access can apply it.

Cheers

Col.


-- 

+------------------------+
|     Colin Guthrie      |
+------------------------+
|   myth at colin.guthr.ie  |
| http://colin.guthr.ie/ |
+------------------------+
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mythmusic.diff
Type: text/x-patch
Size: 2825 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20041211/6db421df/mythmusic.bin


More information about the mythtv-dev mailing list