[mythtv] dvb_on_demand fix

Isaac Richards ijr at po.cwru.edu
Wed Aug 4 11:52:54 EDT 2004


On Wednesday 04 August 2004 06:41 am, Julian Scheel wrote:
> Am Dienstag, 3. August 2004 17:15 schrieb Isaac Richards:
> > On Tuesday 03 August 2004 05:40 am, Julian Scheel wrote:
> > > Am Dienstag, 3. August 2004 00:22 schrieb Isaac Richards:
> > > > On Friday 30 July 2004 08:22 am, Julian Scheel wrote:
> > > > > Any chance to get this commited?
> > > >
> > > > No need for it to be, someone else submitted a similar fix as part of
> > > > a larger patch.
> > >
> > > Christopher Pascoes fixes didn't solve the problem for me. I built this
> > > patch after I aplied his patch.
> >
> > No, you didn't.  Your patch does not apply to what's in CVS.
>
> I had. I just looked into it another time and saw that Christopher added
> the diseqc delete statement into the ~DVBChannel routine, but this does not
> work (for me), because it also has to be deleted, if CloseDVB() is called
> from DVBRecorder. So it has to be in CloseDVB() like it is in my patch. My
> patch may have not applied cleanly, because my CVS version was a few weeks
> old, but I had Christophers patch installed.

This is the patch you sent to the list:

diff -u -w -r1.25 dvbchannel.cpp
--- libs/libmythtv/dvbchannel.cpp       25 Jun 2004 23:31:58 -0000      1.25
+++ libs/libmythtv/dvbchannel.cpp       26 Jul 2004 11:58:16 -0000
@@ -78,6 +78,11 @@
         delete dvbsct;
     if (dvbcam)
         delete dvbcam;
+    if (diseqc)
+    {
+        delete diseqc;
+        diseqc = NULL;
+    }
 
     CloseDVB();
 }

As anyone can see, your patch only adds the delete to the destructor, not to 
CloseDVB().

Isaac


More information about the mythtv-dev mailing list