[mythtv] Crash on FF through aspect change

Kenneth Aafløy ke-aa at frisurf.no
Fri Oct 31 18:12:35 EST 2003


On Fri, 2003-10-31 at 23:52, Edward Wildgoose wrote:
> Fastforwarding through a chunk of video where the aspect ratio changes is
> sometimes causing a segfault in a fairly recent cvs (days old).  It seems to
> be coming from the OSD code, although I'm not quite sure why the re-init
> video call is not already sorting this out...?
> 
> Backtrace is attached

Trying to fix the race!

Kenneth

Index: osd.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/libs/libmythtv/osd.cpp,v
retrieving revision 1.83
diff -u -r1.83 osd.cpp
--- osd.cpp     28 Oct 2003 21:48:30 -0000      1.83
+++ osd.cpp     31 Oct 2003 23:11:41 -0000
@@ -147,6 +147,8 @@
 void OSD::Reinit(int width, int height, int frint, int dispx, int
dispy,
                  int dispw, int disph)
 {
+    osdlock.lock();
+
     vid_width = width;
     vid_height = height;
     if (frint != -1)
@@ -179,6 +181,8 @@

     delete drawSurface;
     drawSurface = new OSDSurface(width, height);
+
+    osdlock.unlock();
 }

 QString OSD::FindTheme(QString name)




More information about the mythtv-dev mailing list