[mythtv] [PATCH] MythGame mamehandler fixes

Morgan Green morgangreen at hotmail.com
Wed Oct 29 04:07:10 EST 2003




>From: Isaac Richards <ijr at po.cwru.edu>
>
>On Tuesday 28 October 2003 11:43 am, Morgan Green wrote:
> > Hi,
> >
> > The attached patch fixes a few problems I noticed while setting up
> > MythGame. The two problems fixed are:
> >
> > * Some of the arguments being passed to the XGL version of xmame were
> > incorrect.  The -nocursor argument doesn't apply to the xgl version and 
>the
> > correct fullscreen argument for xgl xmame is -fullscreen, not -fullview.
> > * Some of the system default settings were being ignored for mame.  For
> > example configuring a mame default joystick type didn't work because 
>that
> > setting was being ignored and the only way to set the joystick type was 
>on
> > a per game basis.
>
>This patch breaks things, see a post from DanM on the October 1st 'MythGame
>mamehandler.cpp'.
>

Isaac, I think you should take another look at this.  I'm pretty sure DanM's 
patch is incorrect.  His post indicates that he intended his patch to keep 
makecmd_line from using uninitialized values, but in fact it is not possible 
for any of these values to be uninitialized.  What his patch actually does 
is keep makecmd_line from using initialized values.

The values are always initialized because:
1) gamedb/metadata.sql creates an initial mamesettings entry in the database 
for romname "default" with default values for all of these settings.
2) The MameHandler constructor calls SetDefaultSettings which loads the 
mamesettings for romname "default" into defaultSettings.
3) makecmd_line calls SetGameSettings to get the game settings it uses to 
construct the command line.
4) the first line of SetGameSettings assigns defaultSettings to 
game_settings thus initializing all of its fields.

-Morgan

_________________________________________________________________
Surf and talk on the phone at the same time with broadband Internet access. 
Get high-speed for as low as $29.95/month (depending on the local service 
providers in your area).  https://broadband.msn.com



More information about the mythtv-dev mailing list