[mythtv] [PATCH] Fix thumbnail creation

Ben Levitt levittben at yahoo.com
Sat Oct 25 16:20:10 EDT 2003


I was having trouble with getting previews to display.
 I am auto-transcoding and auto-commercial-flagging. 
It seems that for some reason, myth thought that my
recordings did not have a full position map.  (Maybe
they don't?  But seeking works fine, and commercials
have been flagged...)

So when nuppeldecoder.cpp tries to open the file for a
screen-grab, it would fail the check for
hasFullPositionMap, and return 0 instead of 1.

The weird thing is that, even though commercials have
already been flagged successfully, if I manually force
mythcommflag to run on these files again, it fixes the
problem.  Do you think this is because commercials
were originally flagged on the ivtv MPEG2, and now the
file is nuppel MPEG4?

Anyway, I made a 1-line change in nuppeldecoder.cpp,
changing the line: 
    if (hasFullPositionMap)
to
    if (hasFullPositionMap || disablevideo)

it now works fine, creates previews, seems to still be
stable...

Anyway, this patch fixes preview creation for me (and
probably also for Bob C.)

Ben

__________________________________
Do you Yahoo!?
Exclusive Video Premiere - Britney Spears
http://launch.yahoo.com/promos/britneyspears/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: previews.patch
Type: application/octet-stream
Size: 621 bytes
Desc: previews.patch
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20031025/bd657a5c/previews.obj


More information about the mythtv-dev mailing list