[mythtv] [PATCH] PVR350 Crash during Sticky Keys FF

Brett Lucey brett at happykoala.com
Fri Oct 24 03:11:29 EDT 2003


Periodically while fast-forwarding in sticky-keys mode, it seems that CommDetect::ProcessNextFrame() gets passed a NULL pointer for the frame.  As a result, a big fat core.  This patch adds a check for the frame being NULL.  I believe the source of this problem is the GetLastDecodedFrame() is returning the NULL but I am not aware of why.  This patch solves the symptom at least.

-Brett


Index: libs/libmythtv/commercial_skip.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/libs/libmythtv/commercial_skip.cpp,v
retrieving revision 1.18
diff -u -r1.18 commercial_skip.cpp
--- libs/libmythtv/commercial_skip.cpp  5 Aug 2003 07:23:37 -0000       1.18
+++ libs/libmythtv/commercial_skip.cpp  24 Oct 2003 06:08:16 -0000
@@ -58,7 +58,7 @@

 void CommDetect::ProcessNextFrame(VideoFrame *frame, long long frame_number)
 {
-    if (frame->codec != FMT_YV12)
+    if (frame == NULL || frame->codec != FMT_YV12)
         return;

     frame_ptr = frame->buf;



-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mythtv.org/pipermail/mythtv-dev/attachments/20031024/13a27db4/attachment.html


More information about the mythtv-dev mailing list