[mythtv] [PATCH] Picture Adjust

Ben Levitt levittben at yahoo.com
Sat Oct 11 18:12:05 EDT 2003


Here is an update to my picture adjust patch.  This
version correctly sets up the brightness, contrast,
saturation, and hue parameters of the display when the
videoout starts.  

It also removes all the NuppleVideoPlayer changes, and
just uses the existing getVideoOutput() to get the
VideoOutput object for picture parameter adjustments.

It now also correctly waits until the osd has faded
away before sending the closed signal.  (Before, it
was sending a close signal both when it finished
fading and when it _Started_ fading... oops.) 

I also think this should work for people using XvMC,
but I can't test that here...

Isaac, I'd love to see this go in to 0.12.  :]  If
there's anything else I can do to help that happen,
please let me know.

Thanks,
Ben


--- Ben Levitt <levittben at yahoo.com> wrote:
> Yeah, yesterday morning, looking back at it, I too
> decided to change the NVP pass throughs to a single
> GetVideoout()...  :)  Sorry not to mention it
> earlier.
> 
> I'm not sure exactly what part of the signal code
> you're not excited about...  One thing I wasn't
> excited about is that the signal is emitted before
> the
> display actually appears to be completely closed.  I
> was wondering if that had to do with buffering
> frames...  I wasn't sure how to fix that...
> 
> I'll work some more on this saturday afternoon, and
> if
> you let me know what direction you'd like the close
> signal to take, I'll try to send you something
> that's
> more like what you're looking for. Unless of course,
> you beat me to it.  :)
> 
> Ben
> 
> 
> --- Isaac Richards <ijr at po.cwru.edu> wrote:
> > On Thursday 09 October 2003 05:03 am, Ben Levitt
> > wrote:
> > > Isaac, if there are any other changes you'd like
> > me to
> > > make please let me know!
> > 
> > Hmm.  Being picky here, but I don't really like
> how
> > the close signal works. 
> > I'd also be tempted to get rid of the pass-through
> > functions in 
> > NuppelVideoPlayer and just make a function that
> > returns the videoOutput 
> > object for tv_play to use.
> > 
> > I'll try to rework things a little.
> > 
> > Isaac 
> > _______________________________________________
> > mythtv-dev mailing list
> > mythtv-dev at mythtv.org
> >
>
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
> 
> 
> __________________________________
> Do you Yahoo!?
> The New Yahoo! Shopping - with improved product
> search
> http://shopping.yahoo.com
> > _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
>
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
> 

__________________________________
Do you Yahoo!?
The New Yahoo! Shopping - with improved product search
http://shopping.yahoo.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pictureAdjust3.patch
Type: application/octet-stream
Size: 27068 bytes
Desc: pictureAdjust3.patch
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20031011/5243ec54/pictureAdjust3.obj


More information about the mythtv-dev mailing list