[mythtv] [PATCH] less crashes when no connection can be made
tobackend
Tako Schotanus
quintesse at palacio-cristal.com
Thu Oct 2 12:37:56 EDT 2003
Not yet, I can keep it from crashing but some parts of the code will
just start waiting on other parts.
What I tried doing was ussuing a StopReads() the moment the RingBuffer's
safe_read() notices that the connection to the backend has been lost.
That works and the user will just see a blank screen instead of a crash.
But it seems that I have to bubble up an error code/state somehow
because what I get are rebuffering pauses and stuff like that. So I
guess other parts of the code just think the connection is slow instead
of gone.
I'll start looking into it again, I had been waiting to see if the
current patch would make it or not before spending more time on it.
Cheers,
-Tako
PS: Don't you think that in your quest for the least possible amount of
comments in the code you even removed my non-obvious comments? ;-)
> -----Original Message-----
> From: mythtv-dev-bounces at mythtv.org
> [mailto:mythtv-dev-bounces at mythtv.org] On Behalf Of Isaac Richards
> Sent: donderdag 2 oktober 2003 9:46
> To: Development of mythtv
> Subject: Re: [mythtv] [PATCH] less crashes when no connection
> can be made tobackend
>
>
> On Wednesday 01 October 2003 05:26 pm, Isaac Richards wrote:
> > New patch looks better, though, I'll see about getting it
> merged in later
> > tonight.
>
> And now it's in CVS -- nice work on the disconnect detection
> stuff. I did
> find a bug in util.c/ReadStringList() where it wasn't
> unlocking the qApp
> mutex on a disconnect.. Bad things happened =) I also added
> a tiny bit of
> code so it can reconnect properly after a disconnect (in most
> cases, I'd
> think).. Probably broke something by doing that, but it
> shouldn't be hard to
> track down if I did. Have you had any luck with it
> disconnecting in live-tv
> mode yet? I can take a look, but it's probably just similar
> changes to the
> ringbuffer and remoteencoder classes.
>
> Isaac
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
>
More information about the mythtv-dev
mailing list