[mythtv] [PATCH] V4L picture controls use same interface as Xv

[Joseph A. Caputo]

On Friday 12 December 2003 00:20, Joseph A. Caputo wrote:
> On Thursday 11 December 2003 21:30, Joseph A. Caputo wrote:
> > The attached patch makes the V4L picture controls (Contrast, Brightness, 
> > Color, Hue) use the same UI as the Xv picture controls (i.e., a single key 
> > toggles through the 4 attributes, with LEFT and RIGHT changing the 
selected 
> > setting).  Not only does it make the UI more consistent, but it eliminates 
> > the current 8 keybindings for these controls and replaces them with just 1 
> > (F1).
> > 
> > I tested it on my box; feel free to tweak the strings in the OSD and the 
> > default keybinding.
> > 
> > -JAC
> 
> 
> Responding to my own post... better hold off on this.  I goofed something 
up; 
> once you play with the V4L picture controls, you can no longer FF/Rew 
> LEFT/RIGHT get stuck in V4L picture control mode.  I post an updated patch 
> soon...
> 
> -JAC

OK, here's a version that works.  The only compromise I had to make to get the 
two picture controls to share common code was to make 'Volume' be the last 
item in the cycle instead of the first.  This is because 'Volume' is in the 
Xv controls cycle, but not in the V4L cycle.  I thought this made sense, as 
'Volume' is (currently) only an output control, not a recording control.  I 
suppose at some point it would be a good idea to add a V4L capture volume 
control, at which point Volume could again be first in both cycles, which 
would be nice in the event you don't have keys mapped for Vol +/-.

Anyway, here it is; have a blast.

-JAC
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v4lcontrols.diff
Type: text/x-diff
Size: 12196 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20031213/853c3ea2/v4lcontrols.bin