[mythtv] [PATCH] MP3 options for TV recording
Matt Zimmerman
mdz at debian.org
Thu Dec 4 19:11:35 EST 2003
On Fri, Dec 05, 2003 at 12:47:22PM +1300, David Zanetti wrote:
> On Thu, 4 Dec 2003, Matt Zimmerman wrote:
>
> > This control does not affect the quality of the algorithm. It should
> > probably be renamed "Quality", regardless of what the underlying setting is
> > named.
>
> Odd, because that's exactly how the function is described in lame.h:
>
> /*
> internal algorithm selection. True quality is determined by the bitrate
> but this variable will effect quality by selecting expensive or cheap
> algorithms.
> quality=0..9. 0=best (very slow). 9=worst.
> recommended: 2 near-best quality, not too slow
> 5 good quality, fast
> 7 ok quality, really fast
> */
> int CDECL lame_set_quality(lame_global_flags *, int);
>
> .. and that's what the mp3quality setting calls even before this patch. I
> note the command-line lame has the same descriptions of the option.
It was a jibe about the wording; "quality of the algorithm" sounds like it's
making the algorithm better, rather than selecting between algorithms of
different quality/expense.
--
- mdz
More information about the mythtv-dev
mailing list