[mythtv-commits] [MythTV/mythtv] 3de8d8: remove README.unzip missed by be856e4cfa16c122d346...

Scott Theisen noreply at github.com
Fri Apr 8 18:39:27 UTC 2022


  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 3de8d8c863da2859ed3027f7987591628a152630
      https://github.com/MythTV/mythtv/commit/3de8d8c863da2859ed3027f7987591628a152630
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-04-08 (Fri, 08 Apr 2022)

  Changed paths:
    R mythtv/libs/libmythbase/README.unzip

  Log Message:
  -----------
  remove README.unzip missed by be856e4cfa16c122d346fd18a5adbab88b40ab3b


  Commit: 1d5a2b40200849db799c10cbd535b70db7611caf
      https://github.com/MythTV/mythtv/commit/1d5a2b40200849db799c10cbd535b70db7611caf
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-04-08 (Fri, 08 Apr 2022)

  Changed paths:
    M mythtv/libs/libmythbase/mythcoreutil.cpp
    M mythtv/libs/libmythbase/mythcoreutil.h
    M mythtv/libs/libmythbase/unzip2.cpp
    M mythtv/libs/libmythbase/unzip2.h

  Log Message:
  -----------
  unzip2: fix use of std::move

The whole point of std::move is to pass by value and let the compiler determine the best way to copy the data only once.

Also, since Qt containers are implicitly shared, passing by value is cheap and what you want to do to avoid dangling references.


  Commit: 53d2c2e2f00f9f931510ececeb412d14a78ed46f
      https://github.com/MythTV/mythtv/commit/53d2c2e2f00f9f931510ececeb412d14a78ed46f
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-04-08 (Fri, 08 Apr 2022)

  Changed paths:
    M mythtv/libs/libmythbase/unzip2.cpp
    M mythtv/libs/libmythbase/unzip2.h

  Log Message:
  -----------
  unzip2: remove defines from header

the users of the header do not need to know these details


  Commit: ed49d1b88f1880cb73347860de4acf68a5270702
      https://github.com/MythTV/mythtv/commit/ed49d1b88f1880cb73347860de4acf68a5270702
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-04-08 (Fri, 08 Apr 2022)

  Changed paths:
    M mythtv/libs/libmythbase/unzip2.h

  Log Message:
  -----------
  unzip2: zipEntry should be a nested private struct of UnZip

It feels like it should also have some of the functions, but it probably doesn't matter
since the compiler should inline all of it.


  Commit: 444d9990106623c0c11a8d2aa1ed9a9a2b575a61
      https://github.com/MythTV/mythtv/commit/444d9990106623c0c11a8d2aa1ed9a9a2b575a61
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-04-08 (Fri, 08 Apr 2022)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttpencoding.cpp
    M mythtv/libs/libmythbase/libmythbase.pro
    M mythtv/libs/libmythbase/mythcoreutil.cpp
    M mythtv/libs/libmythbase/mythcoreutil.h
    M mythtv/libs/libmythbase/test/test_unzip/test_unzip.cpp
    A mythtv/libs/libmythbase/unziputil.cpp
    A mythtv/libs/libmythbase/unziputil.h
    M mythtv/libs/libmythmetadata/musicmetadata.cpp
    M mythtv/libs/libmythupnp/httprequest.cpp
    M mythtv/programs/mythbackend/backendhousekeeper.cpp
    M mythtv/programs/mythbackend/httpconfig.cpp
    M mythtv/programs/mythfrontend/themechooser.cpp

  Log Message:
  -----------
  create unziputil from mythcoreutil


Compare: https://github.com/MythTV/mythtv/compare/a29af93435e0...444d99901066


More information about the mythtv-commits mailing list