[mythtv-commits] [MythTV/mythtv] fc39f5: Disable new clang12 tidy checker.

Thu Mar 25 12:33:57 UTC 2021

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: fc39f52ee7426681e27091c199bf7739fb1659b4
      https://github.com/MythTV/mythtv/commit/fc39f52ee7426681e27091c199bf7739fb1659b4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M .clang-tidy

  Log Message:
  -----------
  Disable new clang12 tidy checker.

  Commit: bcb980a349e02fd44d0843369d5b6ea603238f6f
      https://github.com/MythTV/mythtv/commit/bcb980a349e02fd44d0843369d5b6ea603238f6f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythupnp/httprequest.cpp

  Log Message:
  -----------
  qt6: Use "auto" to handle QMultiMap split from QMap in httprequest.

  Commit: d41774604943e53bebc686df15eb2c60ad579df2
      https://github.com/MythTV/mythtv/commit/d41774604943e53bebc686df15eb2c60ad579df2
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayervideoui.cpp
    M mythtv/libs/libmythui/mythscreenstack.cpp

  Log Message:
  -----------
  qt6: Fix type deduction warnings with Qt6 headers.

  Commit: 1a5ac2dada92a0085253e73d571b749490337622
      https://github.com/MythTV/mythtv/commit/1a5ac2dada92a0085253e73d571b749490337622
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythui/mythfontproperties.cpp
    M mythtv/themes/mythuitheme.xsd

  Log Message:
  -----------
  Update font properties for the Qt5 weight names.

The old names are removed from the xsd but are kept in the code so
they can still be parsed from existing themes.

Qt6 QFont::setWeight takes an enum instead of an integer, so fix the
two cases that break on Qt6.

  Commit: a9b2621e5bcb32d8e37139cc69e4c582d22efb2e
      https://github.com/MythTV/mythtv/commit/a9b2621e5bcb32d8e37139cc69e4c582d22efb2e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythupnp/serializers/serializer.cpp
    M mythtv/libs/libmythupnp/serializers/xmlplistSerializer.cpp
    M mythtv/libs/libmythupnp/xsd.cpp

  Log Message:
  -----------
  qt6: Handle change to QMetaProperty::isDesignable.

In qt6 the QMetaProperty::isDesignable function no longer takes an
argument and operates based on the "this" object.  Since the code is
passing in the object to which the properties are attached, qt5 should
yield the same results with/without passing the object as an argument.

  Commit: c1e82904ab681cd18e94be2cc16816e3ac78cc9a
      https://github.com/MythTV/mythtv/commit/c1e82904ab681cd18e94be2cc16816e3ac78cc9a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp
    M mythtv/libs/libmythtv/captions/cc608decoder.cpp
    M mythtv/libs/libmythtv/eitfixup.cpp
    M mythtv/libs/libmythtv/recorders/HLS/HLSStream.cpp
    M mythtv/libs/libmythtv/recorders/rtp/rtptsdatapacket.h

  Log Message:
  -----------
  qt6: Handle size() change from int to size_t.

None of these values should ever be large enough to overflow an int,
so add a static_cast to make the compiler happy.

  Commit: 178449eb36e379a07f7cd29255a6c117c9bd51f6
      https://github.com/MythTV/mythtv/commit/178449eb36e379a07f7cd29255a6c117c9bd51f6
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythservicecontracts/service.cpp

  Log Message:
  -----------
  Explicitly convert int to QMetaType in service.cpp.

  Commit: 522be0c1c963f3e265a21fc1e53afbcc7e8923c9
      https://github.com/MythTV/mythtv/commit/522be0c1c963f3e265a21fc1e53afbcc7e8923c9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythtv/io/mythiowrapper.cpp

  Log Message:
  -----------
  Simplify s_fileOpenCallbacks access in mythiowrapper.cpp.

The only two functions that access this hash are protected by a lock
so the queue can't change out from underneath them, so they can be
simple runs over the hash. The "register" function doesn't need to use
a QMutableHashIterator (which doesn't exist in Qt6) because it returns
immediately after modifying the hash.

  Commit: 2f6c8b21d1acbb3b8c77106ebd1f977982837c5d
      https://github.com/MythTV/mythtv/commit/2f6c8b21d1acbb3b8c77106ebd1f977982837c5d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythmainwindowprivate.cpp

  Log Message:
  -----------
  Remove references to Qt::UNICODE_ACCEL.

All three uses of this constant were in the form:

    x &= ~Qt::UNICODE_ACCEL;

Given that this constant has the value of zero, this statement is a
NOP and can be removed without affecting code execution.

  Commit: a020b24859a870bac66d75f6e81e738abae836ca
      https://github.com/MythTV/mythtv/commit/a020b24859a870bac66d75f6e81e738abae836ca
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythtv/DVD/mythdvdbuffer.cpp

  Log Message:
  -----------
  qt6: Fix "no match for operator-" warning in DVD code.

  Commit: 4a1b33d60872064fabafef29f8f007e6b40c0d57
      https://github.com/MythTV/mythtv/commit/4a1b33d60872064fabafef29f8f007e6b40c0d57
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythfreemheg/TokenGroup.cpp
    M mythtv/libs/libmythfreemheg/TokenGroup.h

  Log Message:
  -----------
  qt6: Fix "conversion from ‘qsizetype’ to ‘const MHUnion’ is ambiguous" warning.

Qt6 changed the return type of the ::size() function from 'int' to
'qsizetype'. In these cases, the result should never be greater 2^^32
so simply casting back to an 'int' should be sufficient.

  Commit: d93bc03e840e70d2d21c37b3dbb246181af0f3ed
      https://github.com/MythTV/mythtv/commit/d93bc03e840e70d2d21c37b3dbb246181af0f3ed
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmyth/mediamonitor-unix.cpp
    M mythtv/libs/libmyth/mediamonitor-unix.h

  Log Message:
  -----------
  tidy: Fix a couple of warnings.

  Commit: 77e7839168628a4661008c19fc5b81aa8ffa5424
      https://github.com/MythTV/mythtv/commit/77e7839168628a4661008c19fc5b81aa8ffa5424
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmyth/test/test_programinfo/test_programinfo.h

  Log Message:
  -----------
  Fix a "range-loop might detach" warning in test code.

Also turn off debugging.

  Commit: 16815aced76881602f6ca19baa40682ac13988d2
      https://github.com/MythTV/mythtv/commit/16815aced76881602f6ca19baa40682ac13988d2
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythtv/captions/subtitlescreen.cpp

  Log Message:
  -----------
  qt6: Fix invalid conversion from ‘int’ to ‘QFont::Weight’.

  Commit: df98e8b86c21abfc08914a08866f0853abaf2e59
      https://github.com/MythTV/mythtv/commit/df98e8b86c21abfc08914a08866f0853abaf2e59
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M .clazy
    M mythplugins/mythmusic/mythmusic/smartplaylist.cpp
    M mythtv/libs/libmyth/programinfo.cpp
    M mythtv/libs/libmythbase/mythmiscutil.cpp
    M mythtv/libs/libmythtv/AirPlay/mythraopconnection.cpp
    M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp
    M mythtv/libs/libmythtv/HLS/m3u.cpp
    M mythtv/libs/libmythtv/captions/cc608decoder.cpp
    M mythtv/libs/libmythtv/channelscan/inputselectorsetting.cpp
    M mythtv/libs/libmythtv/channelutil.cpp
    M mythtv/libs/libmythtv/diseqcsettings.cpp
    M mythtv/libs/libmythtv/dtvconfparser.cpp
    M mythtv/libs/libmythtv/eitfixup.cpp
    M mythtv/libs/libmythtv/mheg/mhi.cpp
    M mythtv/libs/libmythtv/mythsystemevent.cpp
    M mythtv/libs/libmythtv/playercontext.cpp
    M mythtv/libs/libmythtv/recorders/ExternalRecChannelFetcher.cpp
    M mythtv/libs/libmythtv/recorders/ExternalSignalMonitor.cpp
    M mythtv/libs/libmythtv/recorders/vboxutils.cpp
    M mythtv/libs/libmythtv/sourceutil.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_rec.cpp
    M mythtv/libs/libmythui/mythvirtualkeyboard.cpp
    M mythtv/libs/libmythupnp/ssdp.cpp
    M mythtv/programs/mythfilerecorder/mythfilerecorder.cpp
    M mythtv/programs/mythfilldatabase/channeldata.cpp
    M mythtv/programs/mythfilldatabase/xmltvparser.cpp
    M mythtv/programs/mythfrontend/networkcontrol.cpp
    M mythtv/programs/mythlcdserver/lcdprocclient.cpp

  Log Message:
  -----------
  Remove uses of QStringRef.

This class has been completely removed from Qt6. The cleanest solution
for compiling code on both Qt5 and Qt6 is to revert back to the
QString::left/mid/right functions.

  Commit: 4f6dcf39568b0048bb7cb5298d3222ae348fb4c0
      https://github.com/MythTV/mythtv/commit/4f6dcf39568b0048bb7cb5298d3222ae348fb4c0
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythtv/dtvconfparser.cpp

  Log Message:
  -----------
  Fix "misleading indentation" wwarning.

  Commit: 32a32655c8cd799af7e51c2d4af7d67b532a4a54
      https://github.com/MythTV/mythtv/commit/32a32655c8cd799af7e51c2d4af7d67b532a4a54
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/configure

  Log Message:
  -----------
  Fix configure detection of gcc > 9.

  Commit: 60ae2ac4647e68b059820fb77d5be0cb724f483d
      https://github.com/MythTV/mythtv/commit/60ae2ac4647e68b059820fb77d5be0cb724f483d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/configure

  Log Message:
  -----------
  qt6: Disable -Wsuggest-warnings because of a zillion warnings from Q_OBJECT.

Remove the old restriction on using this flag because Ubuntu 16.04 is
no longer supported, but add a new one because Qt6 causes a zillion
warning messages when this flag is used.

  Commit: d90fd04a6df78720cf8be6d3756375d31da63d29
      https://github.com/MythTV/mythtv/commit/d90fd04a6df78720cf8be6d3756375d31da63d29
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythui/mythdisplay.cpp

  Log Message:
  -----------
  qt6: Disabling High DPI scaling has been removed.

  Commit: b206f42fe20ebec40e0a6a87eac6d2097655b5b1
      https://github.com/MythTV/mythtv/commit/b206f42fe20ebec40e0a6a87eac6d2097655b5b1
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythui/mythmainwindow.cpp

  Log Message:
  -----------
  qt6: Fix "unable to deduce auto*" warnings in main window.

  Commit: 4f5c71bd1deda8f60e668398b0681d03305002b2
      https://github.com/MythTV/mythtv/commit/4f5c71bd1deda8f60e668398b0681d03305002b2
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/vbitext/lang.cpp
    M mythtv/libs/libmythtv/recorders/vbitext/lang.h
    M mythtv/libs/libmythtv/recorders/vbitext/vbi.cpp

  Log Message:
  -----------
  qt6: Fix "declaration shadows a global declaration" warning.

  Commit: 1a64848f9394fb41d69b8f653e33d8b5c2e2d805
      https://github.com/MythTV/mythtv/commit/1a64848f9394fb41d69b8f653e33d8b5c2e2d805
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp

  Log Message:
  -----------
  Make QString->QFileInfo conversion explicit.

  Commit: 17201b84b6acf991f5e5db1144ea521e3de2c7ba
      https://github.com/MythTV/mythtv/commit/17201b84b6acf991f5e5db1144ea521e3de2c7ba
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatacommon.h
    M mythtv/libs/libmythmetadata/metadatafactory.cpp

  Log Message:
  -----------
  qt6: Fix "no match for operator=" warning in metadatacommon.h

This error occurs because QMap and QMultimap have been split into two
separate types.  The argument should have always taken a QMultiMap,
but the problem was never detected before because QMultimap was a
child of QMap.

  Commit: d72523e7af560096392bd99fbfbbf8a1edfb06d3
      https://github.com/MythTV/mythtv/commit/d72523e7af560096392bd99fbfbbf8a1edfb06d3
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythmetadata/imagethumbs.cpp

  Log Message:
  -----------
  qt6: Handle QMap/QMultimap split in imagethumbs.cpp.

  Commit: 2c643bfa721d92215e0f3ee4f26b5114f3d81b32
      https://github.com/MythTV/mythtv/commit/2c643bfa721d92215e0f3ee4f26b5114f3d81b32
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythmetadata/imagemanager.cpp

  Log Message:
  -----------
  qt6: Handle QVector becoming an alias for QList in imagaemanager.cpp.

  Commit: 0a2be2b8d34abc6fa85e1c91fc366111d7f523a2
      https://github.com/MythTV/mythtv/commit/0a2be2b8d34abc6fa85e1c91fc366111d7f523a2
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythmetadata/bluraymetadata.cpp

  Log Message:
  -----------
  Add fields to BlurayMetadata::ToMap.

There are two fields in this map whose value is presented as a single
UTF16 character.  New fields have been added to present the values in
a different way. They have had "<id>_str" fields added to the map that
presents the number as a string.  I.E. The titles field might be
presented as the two character string "12" instead of a one character
string containing QChar(12).

  Commit: 0fa232b4f61c4535cdfe79fdde89bdba62d621b5
      https://github.com/MythTV/mythtv/commit/0fa232b4f61c4535cdfe79fdde89bdba62d621b5
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythmetadata/imagemanager.cpp

  Log Message:
  -----------
  qt6: Can't add an interator and a number in imagemanager.cpp

  Commit: f1f320ee0c4e47f07437f88498d35ee08ebd6a03
      https://github.com/MythTV/mythtv/commit/f1f320ee0c4e47f07437f88498d35ee08ebd6a03
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/mythvaapicontext.cpp

  Log Message:
  -----------
  Fix "loop variable ‘profile’ creates a copy" warning.

  Commit: a77028ae7e83df6527aebc507b8b02bf9ed81f50
      https://github.com/MythTV/mythtv/commit/a77028ae7e83df6527aebc507b8b02bf9ed81f50
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/programs/mythbackend/mainserver.h
    M mythtv/programs/mythbackend/scheduler.cpp
    M mythtv/programs/mythbackend/scheduler.h

  Log Message:
  -----------
  Fix "declaration shadows a global declaration" warnings in backend.

  Commit: a0515a5b4aaa2ff8e96e271716de0630e18738b8
      https://github.com/MythTV/mythtv/commit/a0515a5b4aaa2ff8e96e271716de0630e18738b8
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
    M mythtv/libs/libmythtv/tv_rec.cpp

  Log Message:
  -----------
  Fix "'this' pointer is null" warnings.

The dynamic_cast function can return a nullptr, so need to test that
the result is not nullptr.

Compare: https://github.com/MythTV/mythtv/compare/485ea54181a4...a0515a5b4aaa