[mythtv-commits] [MythTV/mythtv] aa49df: Fail gracefully when render is missing

Stuart Auchterlonie noreply at github.com
Wed Jul 14 14:10:50 UTC 2021


  Branch: refs/heads/devel/http
  Home:   https://github.com/MythTV/mythtv
  Commit: aa49df6d3c4a1933b188f0b2763f5d7bf8ce65ff
      https://github.com/MythTV/mythtv/commit/aa49df6d3c4a1933b188f0b2763f5d7bf8ce65ff
  Author: Klaas de Waal <klaas at kldo.nl>
  Date:   2021-06-30 (Wed, 30 Jun 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayervisualiserui.cpp

  Log Message:
  -----------
  Fail gracefully when render is missing

Fix segfault of mythfrontend when trying to play a recording
from a remote frontend on a local display, via a "ssh -X" connection.
This does not fix the remote playback but it now falls back into the
GUI with an error message popup instead of segfaulting.


  Commit: df9e32bde661c6839fcf2160bc2d49729c8befd1
      https://github.com/MythTV/mythtv/commit/df9e32bde661c6839fcf2160bc2d49729c8befd1
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  Display track titles when choosing an audio track.

Part of the audio track data provided by FFmpeg is a user defined
track title, which could be anything from the simple label "Stereo" to
the more descriptive label "Commentary". Display this track title to
the user when they are choosing between audio tracks.


  Commit: f058c1680c6bd8fa3ab66730be03fd4a2c9f6ea8
      https://github.com/MythTV/mythtv/commit/f058c1680c6bd8fa3ab66730be03fd4a2c9f6ea8
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M mythtv/programs/mythfrontend/programinfocache.cpp

  Log Message:
  -----------
  Fix crash in ProgramInfoCache::Refresh when built with Qt6.

1) Don't release the lock until after items are deleted.

2) Don't try to cache the "next" iterator across a call to
   QHash::erase. This function can internally rearrange the contents
   of the hash and invalidate any iterators. It does explicitly return
   the next iterator after the one that was erased, so use that value
   to continue walking the hash.


  Commit: 3c8bae9e7f960f5e6f61c9e15fedb38b85f59a20
      https://github.com/MythTV/mythtv/commit/3c8bae9e7f960f5e6f61c9e15fedb38b85f59a20
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/atsctables.h

  Log Message:
  -----------
  Simplify earlier commit that used be16toh.

See e52e3ff7499703eec33b41ba5c9e069998c0e712.


  Commit: f5c480dad41c272072ca8ca6bd2ef427d1c81e6c
      https://github.com/MythTV/mythtv/commit/f5c480dad41c272072ca8ca6bd2ef427d1c81e6c
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M mythtv/libs/libmythtv/AirPlay/mythraopdevice.cpp
    M mythtv/libs/libmythtv/recorders/firewiredevice.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_rec.cpp
    M mythtv/libs/libmythui/mythscreenstack.cpp

  Log Message:
  -----------
  Don't cache iterators across a call to a Qt ::erase function. (libs)

Don't try to cache the "next" iterator across a call to QHash::erase
or QMap::erase. These functions can internally rearrange the contents
of the hash and invalidate any iterators. They do explicitly return
the next iterator after the one that was erased, so use that value to
continue walking the hash.


  Commit: 4f14a75cae01bf0ba13f6e4b74413ad6ec2bada8
      https://github.com/MythTV/mythtv/commit/4f14a75cae01bf0ba13f6e4b74413ad6ec2bada8
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M mythtv/programs/mythbackend/mainserver.cpp

  Log Message:
  -----------
  Don't cache iterators across a call to a Qt ::erase function. (mainserver)

Don't try to cache the "next" iterator across a call to QHash::erase
or QMap::erase. These functions can internally rearrange the contents
of the hash and invalidate any iterators. They do explicitly return
the next iterator after the one that was erased, so use that value to
continue walking the hash.

This may not be a complete solution, since this code is running two
iterators across the same hash. Its possible that both iterators get
invalidated.


  Commit: 6ad914b9b1389989b401c13e4b9d4fdde43cbd53
      https://github.com/MythTV/mythtv/commit/6ad914b9b1389989b401c13e4b9d4fdde43cbd53
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M mythtv/programs/mythcommflag/BlankFrameDetector.cpp
    M mythtv/programs/mythcommflag/FrameAnalyzer.cpp

  Log Message:
  -----------
  Don't cache iterators across a call to a Qt ::erase function. (mythcommflag)

Don't try to cache the "next" iterator across a call to QHash::erase
or QMap::erase. These functions can internally rearrange the contents
of the hash and invalidate any iterators. They do explicitly return
the next iterator after the one that was erased, so use that value to
continue walking the hash.


  Commit: 4eaa9cdbad0552d61f71a48019cbc6f9b1a14209
      https://github.com/MythTV/mythtv/commit/4eaa9cdbad0552d61f71a48019cbc6f9b1a14209
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M mythtv/libs/libmythtv/tv_play.cpp

  Log Message:
  -----------
  Eliminate duplicate calls to TV::customEvent.

The TV::customEvent function receives a number of MythTV generated
events directly from the Qt event dispatcher. The TV object also
registers to filter all events that are about to be sent to the
MythMainWindow object, so it sees these same events a second time in
the TV::filterEvent function before they are allowed to be sent to the
MythMainWindow::event function. TV::eventFilter should not forward
these events to TV::customEvent for processing, since they've already
been processed by that function.


  Commit: 4d21b95e4f063f586663b3d2bd4712139a919d56
      https://github.com/MythTV/mythtv/commit/4d21b95e4f063f586663b3d2bd4712139a919d56
  Author: Klaas de Waal <klaas at kldo.nl>
  Date:   2021-07-05 (Mon, 05 Jul 2021)

  Changed paths:
    M mythtv/libs/libmythtv/frequencytables.cpp

  Log Message:
  -----------
  US ATSC uscable channel 159 removed from channel scan

When doing a channel scan with mythtv-setup for ATSC cable, choice "uscable",
the scan range includes channel 159 corresponding to a frequency of 1005MHz.
Scanning this channel with a HDHomeRun fails with an "ERROR: invalid channel" error message.
Consulting the Wikipedia, https://en.wikipedia.org/wiki/Pan-American_television_frequencies,
shows that the highest channel number is 158 and that channel 159 does not exist.


  Commit: 129fa26a6361a3a264e7f4ce37d23b6d07704cb7
      https://github.com/MythTV/mythtv/commit/129fa26a6361a3a264e7f4ce37d23b6d07704cb7
  Author: Stuart Auchterlonie <stuarta at mythtv.org>
  Date:   2021-07-14 (Wed, 14 Jul 2021)

  Changed paths:
    M mythtv/libs/libmythtv/AirPlay/mythraopdevice.cpp
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/frequencytables.cpp
    M mythtv/libs/libmythtv/mpeg/atsctables.h
    M mythtv/libs/libmythtv/mythplayervisualiserui.cpp
    M mythtv/libs/libmythtv/recorders/firewiredevice.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_rec.cpp
    M mythtv/libs/libmythui/mythscreenstack.cpp
    M mythtv/programs/mythbackend/mainserver.cpp
    M mythtv/programs/mythcommflag/BlankFrameDetector.cpp
    M mythtv/programs/mythcommflag/FrameAnalyzer.cpp
    M mythtv/programs/mythfrontend/programinfocache.cpp

  Log Message:
  -----------
  Merge branch 'master' into devel/http


Compare: https://github.com/MythTV/mythtv/compare/56d9d650f464...129fa26a6361


More information about the mythtv-commits mailing list